Discovery aids for Gate in USB EP #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 1, 2025 17:30
themarpe
reviewed
Oct 6, 2025
src/pc/protocols/usb_host_ep.cpp
Outdated
| #include <fcntl.h> | ||
| #endif | ||
|
|
||
| #include <stdint.h> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include <stdint.h> | |
| #include <cstdint> |
src/pc/PlatformDeviceControl.c
Outdated
| #endif | ||
|
|
||
| if (usbEpInitialize() != 0) { | ||
| xlinkSetProtocolInitialized(X_LINK_USB_EP, 0); |
src/pc/protocols/usb_host_ep.cpp
Outdated
| return error; | ||
| } | ||
|
|
||
| // Try claiming interface 0 to test if it's in use |
Collaborator
There was a problem hiding this comment.
We need to go directly to INTERFACE_XLINK & INTERFACE_GATE by interface index, instead of searching for it
src/pc/protocols/usb_host_ep.cpp
Outdated
|
|
||
|
|
||
| int usbEpPlatformGateRead(void *data, int size) | ||
| { |
Collaborator
There was a problem hiding this comment.
Each R/W opening & closing USB device - lets leave it for now, for initial DAI impl.
But, we might want to move that DeviceGate session has a "opened device" as well
src/pc/protocols/usb_host.cpp
Outdated
Comment on lines
584
to
589
| char *serialStr = (char*)malloc(serialStrLen + 1); | ||
| memcpy(serialStr, (const char*)&respBuffer[0], serialStrLen); | ||
| serialStr[serialStrLen] = '\0'; | ||
| serial = serialStr; | ||
| free(serialStr); | ||
| outSerial = serial; |
Collaborator
There was a problem hiding this comment.
Suggested change
| char *serialStr = (char*)malloc(serialStrLen + 1); | |
| memcpy(serialStr, (const char*)&respBuffer[0], serialStrLen); | |
| serialStr[serialStrLen] = '\0'; | |
| serial = serialStr; | |
| free(serialStr); | |
| outSerial = serial; | |
| serial.resize(serialStrLen); | |
| for(int i = 0; i < serialStrLen; i++){ | |
| serial[i] = ... | |
| } |
| } | ||
| return getLocalShdmemDevices(in_deviceRequirements, out_foundDevices, sizeFoundDevices, out_amountOfFoundDevices); | ||
| #endif | ||
|
|
Collaborator
There was a problem hiding this comment.
unnecessary whitespace diff
src/pc/PlatformDeviceSearch.c
Outdated
| } | ||
|
|
||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
unnecessary whitespace diff
src/pc/protocols/usb_host.cpp
Outdated
| { | ||
| mvLog(MVLOG_DEBUG, "cannot open device: %s\n", xlink_libusb_strerror(res)); | ||
| return (libusb_error) res; | ||
| return (libusb_error) res; |
Collaborator
There was a problem hiding this comment.
unnecessary whitespace diff
themarpe
reviewed
Oct 6, 2025
src/pc/protocols/usb_host.cpp
Outdated
| int rc = 0; | ||
|
|
||
| /* Get our device */ | ||
| libusb_device_handle *gate_dev_handle = libusb_open_device_with_vid_pid(context, 0x05C6, 0x4321); |
Collaborator
There was a problem hiding this comment.
Use: usbPlatformConnect, usbPlatformClose
(if not at all possible, then usbLinkOpen or refLibusbDeviceByName)
src/pc/protocols/usb_host.cpp
Outdated
| return rc; | ||
| } | ||
|
|
||
| int usbPlatformGateRead(void *data, int size, int timeout) |
Collaborator
There was a problem hiding this comment.
Suggested change
| int usbPlatformGateRead(void *data, int size, int timeout) | |
| int usbPlatformGateRead(name or deviceInfo, void *data, int size, int timeout) |
themarpe
requested changes
Oct 7, 2025
src/pc/PlatformDeviceControl.c
Outdated
| case X_LINK_USB_VSC: | ||
| case X_LINK_USB_CDC: | ||
| return usbPlatformClose(deviceHandle->xLinkFD); | ||
| case X_LINK_USB_EP: |
Collaborator
There was a problem hiding this comment.
Suggested change
| case X_LINK_USB_EP: | |
| case X_LINK_USB_EP: |
| memset(out_foundDevices[numDevicesFound].mxid, 0, sizeof(out_foundDevices[numDevicesFound].mxid)); | ||
| strncpy(out_foundDevices[numDevicesFound].mxid, mxId.c_str(), sizeof(out_foundDevices[numDevicesFound].mxid)); | ||
| numDevicesFound++; | ||
|
|
cmake/XLinkDependencies.cmake
Outdated
| add_subdirectory("${XLINK_LIBUSB_LOCAL}" "${CMAKE_CURRENT_BINARY_DIR}/libusb" EXCLUDE_FROM_ALL) | ||
| elseif(XLINK_LIBUSB_SYSTEM) | ||
| find_package(PkgConfig REQUIRED) | ||
| pkg_check_modules(LIBUSB REQUIRED libusb-1.0) |
Collaborator
There was a problem hiding this comment.
whitespace - use spaces: 4 on vscode
themarpe
requested changes
Oct 8, 2025
Collaborator
themarpe
left a comment
themarpe
left a comment
There was a problem hiding this comment.
Added my comments that have to be addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This patch gets the state and the platform from gate dynamically.
Specification
Inside the USB EP device discovery functions, once the device is found a request is sent to Gate to get discovery information, and that is used to determine the device state and platform
Dependencies & Potential Impact
This must be paired with the Gate update to make it function correctly.
Deployment Plan
First, the Gate patch must be released to allow for this to work and to allow for testing.
Testing & Validation
For correct testing, first DepthAI Gate must be merged