Open
Conversation
luzzif
requested changes
Oct 15, 2019
Owner
luzzif
left a comment
luzzif
left a comment
There was a problem hiding this comment.
Thank you so much for the contribution and sorry for the late response.
I'm going to add a linter to the project so that those spacing problems get automatically fixed once you align the PR fixed, then just the console log is a problem.
|
|
||
|
|
||
| const priceAsString: string = price.toFixed(8); | ||
| console.log("BinanceApiClient says the price is" + priceAsString); |
| interval: CandlestickInterval, | ||
| onUpdate: ( update: CandlestickUpdate ) => any, | ||
| connectionTimeout?: number, | ||
| onLostConnection?: () => any ): Promise< void > { |
Owner
There was a problem hiding this comment.
I'd remove the spaces in the diamond notation here. And it's my bad, I should add a linter to the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all the changes I've made on my branch. In a nut shell,
Take or leave whatever you want!