Refactor agent executors, improve CLI presentation, and update prompts/docs#159
Refactor agent executors, improve CLI presentation, and update prompts/docs#159
Conversation
Enhance the CLI presentation layer by updating renderer behavior, adding an ink presentation service, and improving markdown formatting/service code. Add tests and a code theme for presentation consistency.
Refactor agent execution paths by updating batch, streaming, and tool executors; reorganize base tool abstractions and tool registration to simplify tool lifecycle and user interaction tools. Update related types and interfaces.
Update default and researcher system prompts and adjust AI SDK service integration in the LLM service. Minor app-layer adjustments to reflect prompt/service changes.
Update the deep-research skill documentation to reflect new behavior, prompts, or examples.
Summary of ChangesHello @lvndry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors core agent execution mechanisms, enhances the command-line interface's presentation, and updates agent prompts and skill documentation. The changes aim to improve agent capabilities through sub-agent delegation and context management, provide a more polished and informative user experience in the CLI, and guide agents towards more effective task-solving strategies. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements to the agent's capabilities, including sub-agent execution, improved CLI presentation with theming, and more robust handling of provider-native tools. The refactoring of signal handling for graceful shutdown is a great improvement for stability. My review focuses on ensuring consistency in the new features and preventing potential bugs in the streaming execution path. I've identified a critical issue in the streaming logic for provider-native tools and a couple of medium-severity improvement opportunities in the new sub-agent tools for better robustness and consistency.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This is a substantial pull request that introduces significant new capabilities, most notably the agent executor refactoring to support sub-agents. The addition of spawn_subagent and summarize_context tools opens up powerful new patterns for agent workflows. The improvements to CLI presentation, especially the more robust handling of provider-native tools and the new color theme for code, enhance the user experience. The extensive updates to system prompts are also a welcome change, steering the agent towards more reliable and hierarchical tool usage. The code is well-structured, and the changes are consistent across the codebase. The identified issues, one related to markdown formatting and another to improving logging for a specific configuration scenario, remain valid. Overall, this is an excellent set of changes.
No description provided.