Conversation
|
|
||
| // List file/objects filter by given query. This just wraps the object-iterator | ||
| // returning full list of objects. | ||
| func (f *FS) List(ctx context.Context, q cloudstorage.Query) (*cloudstorage.ObjectsResponse, error) { |
There was a problem hiding this comment.
I am assuming these are not implemented because you didn't need them? Ie, would be available for implementation at some point as opposed to their api doesn't support it? Just curious.
There was a problem hiding this comment.
Hi Araddon, I am looking at https://godoc.org/gopkg.in/kothar/go-backblaze.v0 and I found that there's a list method: func (b *Bucket) ListFileNames(startFileName string, maxFileCount int) (*ListFilesResponse, error). Maybe I could implement your interface using it. But I think that context doesn't matter in this case.
backblaze/store_test.go
Outdated
| func TestConfig(t *testing.T) { | ||
|
|
||
| if config.Bucket == "" { | ||
| t.Logf("must provide BACKBLAZE_BUCKET, BACKBLAZE_ACCESS, BACKBLAZE_KEY env vars") |
There was a problem hiding this comment.
This comment seems wrong? Should be BACKBLAZE_ACCOUNT ? not access?
|
I created backblaze account for testing, and added env vars to travis and running now https://travis-ci.org/lytics/cloudstorage |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
===========================================
- Coverage 64.89% 20.48% -44.42%
===========================================
Files 13 13
Lines 1997 1997
===========================================
- Hits 1296 409 -887
- Misses 491 1522 +1031
+ Partials 210 66 -144
Continue to review full report at Codecov.
|
|
Araddon, your test target does not match the actual code quality :) Could you review it to approve my request? Thank you. |
|
Not entirely sure what is going on with this pr re the import paths? They can't be merged in while pointing to your personal fork. Is your local-directory structure mirroring this github path? ie /home/dvriesman/go/src/github.com/lytics/cloudstorageWith the cloudstorage .git/config having an upstream pointing to github.com/lytics/cloudstorage and non-upstream pointing at your personal-repo fork? |
|
|
||
| "github.com/lytics/cloudstorage" | ||
| "github.com/lytics/cloudstorage/csbufio" | ||
| "github.com/dvriesman/cloudstorage" |
There was a problem hiding this comment.
@dvriesman I assume this can not be merged here with changed import paths
4 participants
Included support to send and receive files to/from Backblaze