25 pdf extracted fonts can not be loaded in browser#26
25 pdf extracted fonts can not be loaded in browser#26tomsontom wants to merge 5 commits intom-abboud:masterfrom
Conversation
|
Awesome thank you for the PR. Code looks good except for some minor formatting issues, don't include spaces inside parentheses blocks (sorry I never set up some sort of linter for this project) |
| if (getNameTable() == null) | ||
| if (getNameTable() == null) { | ||
| setName(NameTable.createDefaultTable()); | ||
| } else { |
There was a problem hiding this comment.
unfortunately these changes surface a bug in NameTable - i have a fix for that but if you want I can rollback those changes and provide another PR to fix this
There was a problem hiding this comment.
the problem is in the offset-computation where there are 2 problems:
- it's not guaranteed that the length of the string has been computed
- the offset computation is done BEFORE the entries are sorted
I think currently one most of the time does not recognize that because if one call normalize() and then getData() the content is correct because on the get data-call
There was a problem hiding this comment.
Oh if you have a fix for it you can just throw it into this PR. I unfortunately haven't worked on this project in a long time so I'm not really familiar with the specifics here (I also haven't touched java in years either)
2 participants
Normalize "Format6SubTable" to default tables if they are not present yet
Closes #25