-
Notifications
You must be signed in to change notification settings - Fork 2
OZ timelock deployment #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds deployment infrastructure for OpenZeppelin's TimelockController contract, including a deployment script, comprehensive test suite, and Makefile integration for Sepolia deployment.
Key changes:
- Added
DeployTimelock.solscript with parameter validation and deployment logic - Created comprehensive test suite with 11 test cases covering edge cases and role assignments
- Extended Makefile with
deploy-timelocktarget and environment variable configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script/deploy/DeployTimelock.sol | Core deployment script with validation and TimelockController instantiation |
| test/DeployTimelock.t.sol | Test suite validating deployment scenarios, role assignments, and parameter handling |
| Makefile | Added deployment target with environment variable configuration |
| .env.example | Added example configuration for timelock deployment parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
script/deploy/DeployTimelock.sol
Outdated
| @@ -0,0 +1,61 @@ | |||
|
|
|||
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the empty line at the beginning of the file. The file should start directly with the SPDX license identifier comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved -> a104cad
.env.example
Outdated
| # update with your mnemonic | ||
| MNEMONIC="test test test test test test test test test test test junk" | ||
|
|
||
| # .env |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment '# .env' is redundant since this is already the .env.example file. Consider removing it or replacing it with a more descriptive comment about the section below.
| # .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved -> a104cad
| TIMELOCK_MIN_DELAY=259200 # 3 days in seconds | ||
| TIMELOCK_PROPOSERS=0x1234567890123456789012345678901234567890,0x0987654321098765432109876543210987654321 | ||
| TIMELOCK_EXECUTORS=0x13cb6ae34a13a0977f4d7101ebc24b87bb23f0d5,0x14cb6ae34a13a0977f4d7101ebc24b87bb23f0d6 | ||
| TIMELOCK_ADMIN=0x0000000000000000000000000000000000000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 0x0 address for the actual deployments
|
looks great, I doubt common is the best repo for this script though |
Cool, will submit a PR there and close this one then, thank you! |
|
Closing, team decided better to add to |
Added OZ timelock deployment script