Reduce settings log noise#137
Open
NaitikRishu wants to merge 2 commits intom2b3:mainfrom
Open
Conversation
Author
|
Issue observed during local setup: settings printed runtime config values and always enabled SQL query logs in debug mode, which made logs noisy and harder to use. This PR removes the prints and introduces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes noisy startup logging from Django settings and makes SQL query logging opt-in in debug mode.
Problem
While running locally, settings were printing runtime config values at startup (including DB/Redis-related values), and SQL query logging was always enabled when
DEBUG=True, which created excessive log noise.Changes
print(...)calls frommyapp/settings.pyLOG_SQL_DEBUGenv var (defaultFalse)django.db.backends) now only enables when:DEBUG=TrueLOG_SQL_DEBUG=True.env.exampledocs/ENV_TEMPLATE.mdWhy
Validation
poetry run python manage.py checkpassedpoetry run python manage.py migrate --noinputpassed