Fix invalid %f datefmt in logging config causing errors on Windows#151
Open
xenacode-art wants to merge 10 commits intom2b3:testfrom
Open
Fix invalid %f datefmt in logging config causing errors on Windows#151xenacode-art wants to merge 10 commits intom2b3:testfrom
xenacode-art wants to merge 10 commits intom2b3:testfrom
Conversation
Sync Alphatest with Test
Sync Main with AlphaTest
Sync test with alphatest
Sync main with Alphatest
Sync AlphaTest with Test
Sync Main with Alphatest
change MAX_COMMUNITIES_PER_USER to 40
change MAX_COMMUNITIES_PER_USER to 40
Collaborator
|
The PR looks good, but please create a PR to the |
Author
|
thank you @armanalam03 i have retargeted it, i will do same for all the PR i opened too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid %f datefmt in logging config causing errors on Windows
%f is valid in Python's datetime.strftime() but not in the C-level time.strftime() used internally by the logging module. On Windows this raises a
ValueError on every log line, flooding the terminal and making it unusable during local development.
Removed ,%f from both logging formatter configs in settings.py (lines 344 and 380).
Fixes #138