Fix edit article requiring double click (#255)#347
Open
Fix edit article requiring double click (#255)#347
Conversation
Author
|
Hi maintainers, I investigated this issue and found that the edit action was not triggering properly on the first click due to event handling/state timing. I have fixed the logic so that it works reliably on the first click. Please let me know if you'd like me to extend this fix to similar interactions across the app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The edit article action required two clicks to trigger due to improper event handling / state or routing issues.
Root Cause
The "Edit Article" button on the article display page was navigating to the settings page without specifying the edit intent. The settings page required an
edit=truequery parameter to automatically activate the edit mode. Without this, users had to click an additional "Edit" button once on the settings page.Solution
Updated the link in the "Edit Article" button to include the
edit=truequery parameter, ensuring that navigation leads directly to the edit interface on the first click.Implementation
src/components/articles/DisplayArticle.tsxto add?edit=trueto the settings link.Testing
Fixes Edit article requires two clicks #255.