Fix background exposure issue in mobile view (#257)#348
Open
Fix background exposure issue in mobile view (#257)#348
Conversation
Author
|
Hi, I noticed a previous PR (#258) addressed a similar issue. I have reworked the solution and tested it for consistent behavior across different mobile screen sizes. Please let me know if further improvements are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Background was not fully covering screen in mobile view when bottom drawer was open.
Root Cause
The root cause was the
vaul-drawer-wrapperscaling down on mobile while the underlyingbodyandhtmlbackgrounds were set to white/near-white. This revealed the background gaps in light mode.Solution
htmlandbodybackground tobg-blackinsrc/app/layout.tsx.src/hooks/useScaleBackground.tsby settingnoBodyStyles = false.Testing
Verified in mobile view simulation; the background now remains dark during the scale transition, providing a professional depth effect without white gaps.