fix: prevent navbar back button from navigating to external sources#357
Open
piyushupadhyay19 wants to merge 1 commit intom2b3:sureshDevfrom
Open
fix: prevent navbar back button from navigating to external sources#357piyushupadhyay19 wants to merge 1 commit intom2b3:sureshDevfrom
piyushupadhyay19 wants to merge 1 commit intom2b3:sureshDevfrom
Conversation
Author
|
@bsureshkrishna Please check this. This is ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Prevent navbar back button from navigating to external sources
Description:
Fixes an issue where the navbar's back button would navigate the user back to an external source like Google Search or a new tab if they had just landed on the application from there. It now correctly disables the back button when there is no internal navigation history.
Previously:
Previously.mp4
Now after this update:
Currently.mp4
Resolves #312