refactor: Migrate Internal Config class to kotlin #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mansi-mParticle
force-pushed
the
blackout-2024
branch
from
35ae7c8 to
38adc3c
Compare
Mansi-mParticle
force-pushed
the
refactor/SQDSDKS-6708-Configmanager-class
branch
from
5de2f41 to
3a5292e
Compare
einsteinx2
suggested changes
Feb 6, 2025
Contributor
einsteinx2
left a comment
einsteinx2
left a comment
There was a problem hiding this comment.
Couple of questions, otherwise looks good
android-core/src/main/kotlin/com/mparticle/internal/ConfigManager.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+524
to
+528
| open val apiKey: String | ||
| get() = sPreferences?.getString(Constants.PrefKeys.API_KEY, null) ?: "" | ||
|
|
||
| open val apiSecret: String | ||
| get() = sPreferences?.getString(Constants.PrefKeys.API_SECRET, null) ?: "" |
Contributor
There was a problem hiding this comment.
I notice in the original Java we return null for both of these if it's not stored. Should these properties be nullable and return null instead of an empty string? Are there any null checks in other places that assume this can return null?
Collaborator
Author
There was a problem hiding this comment.
it is returning null it breaking lot's of existing code and test cases so decide to keep this as non null
Mansi-mParticle
requested review from
BrandonStalnaker,
mmustafa-tse and
rmi22186
and removed request for
einsteinx2
BrandonStalnaker
approved these changes
Mar 3, 2025
Contributor
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
LGTM but would appreciate another set of eyes to take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)