Skip to content

feat: Update Android Gradle plugin to 8.1.0 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Update Android Gradle plugin to 8.1.0 #575

wants to merge 8 commits into from

Conversation

@Mansi-mParticle
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle commented Apr 29, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR updates the Android Gradle Plugin to version 8.1.0.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested it with a sample app and ran the test cases.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-7068-gradle-8 branch from c42b9d3 to c80d354 Compare April 30, 2025 14:38
BrandonStalnaker
BrandonStalnaker previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-7068-gradle-8 branch from a673322 to 4c030ef Compare May 15, 2025 15:44
@Mansi-mParticle Mansi-mParticle requested a review from samdozor May 15, 2025 16:33
samdozor
samdozor requested changes May 15, 2025
View reviewed changes
android-core/build.gradle Outdated
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
Copy link
Contributor

@samdozor samdozor May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this impact clients? do they need to build their app with 17 when compiling against our SDK? is that ok?

Copy link
Collaborator Author

@Mansi-mParticle Mansi-mParticle May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can affect the client app, but Android Gradle Plugin 8 requires at least Java 17 to run.

gradle.properties Outdated
#-XX:ThreadStackSize=4096 -XX:CompilerThreadStackSize=4096
#-XX:ThreadStackSize=4096 -XX:CompilerThreadStackSize=4096
android.defaults.buildfeatures.buildconfig=true
org.gradle.caching=true
Copy link
Contributor

@samdozor samdozor May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to mess up CI builds? we shouldn't be caching for CI

Copy link
Collaborator Author

@Mansi-mParticle Mansi-mParticle May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed org.gradle.caching=true because the build cache can affect CI

@Mansi-mParticle Mansi-mParticle requested a review from samdozor May 15, 2025 18:50
@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner June 25, 2025 19:53
jamesnrokt
jamesnrokt reviewed Jun 26, 2025
View reviewed changes
thomson-t
thomson-t reviewed Jun 30, 2025
View reviewed changes
thomson-t
thomson-t reviewed Jun 30, 2025
View reviewed changes
@jamesnrokt jamesnrokt mentioned this pull request Jul 2, 2025
Closed
1 task
thomson-t
thomson-t previously approved these changes Jul 4, 2025
View reviewed changes
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-7068-gradle-8 branch from 66afa0f to 69d8a8a Compare September 29, 2025 18:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-7068-gradle-8 branch from 69d8a8a to 8b19174 Compare November 19, 2025 22:36
@Mansi-mParticle Mansi-mParticle changed the base branch from development to main November 19, 2025 22:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesnrokt jamesnrokt jamesnrokt left review comments

@BrandonStalnaker BrandonStalnaker BrandonStalnaker left review comments

@thomson-t thomson-t thomson-t left review comments

@rmi22186 rmi22186 Awaiting requested review from rmi22186

@mmustafa-tse mmustafa-tse Awaiting requested review from mmustafa-tse

@samdozor samdozor Awaiting requested review from samdozor

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mansi-mParticle @samdozor @BrandonStalnaker @thomson-t @jamesnrokt