feat: Create Logging Service #1123
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
… up imports in reportingLogger
… window for location and ROKT_DOMAIN
gtamanaha
commented
Nov 25, 2025
src/mp-instance.ts
Outdated
| // Some (server) config settings need to be returned before they are set on SDKConfig in a self hosted environment | ||
| function completeSDKInitialization(apiKey, config, mpInstance) { | ||
| const kitBlocker = createKitBlocker(config, mpInstance); | ||
| function completeSDKInitialization(apiKey, config, mpInstance, kitBlocker: KitBlocker) { |
Contributor
Author
There was a problem hiding this comment.
The Cognitive Complexity fix from below won't be part of this PR. We are just adding new parameter to this function.
…locker parameter from related functions
…Uploader and XHRUploader
…proved type safety
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)