"feat: allow cookie-based auth to bypass recaptcha" #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2za
requested changes
Apr 28, 2025
substack/api.py
Outdated
| if not custom_domain: | ||
| publication_url = f"https://{publication['subdomain']}.substack.com" | ||
| else: | ||
| if publication['custom_domain_optional']: |
There was a problem hiding this comment.
this should be a get to avoid KeyError for the custom_domain_optional key
There was a problem hiding this comment.
ok i fix this issue in this commit
substack/cookie_session.py
Outdated
| super().__init__() | ||
| with open(cookie_file, "r", encoding="utf-8") as f: | ||
| raw = json.load(f) | ||
| self.cookies = cookiejar_from_dict({c["name"]: c["value"] for c in raw}) |
There was a problem hiding this comment.
does this fully replace the cookies with the content of the json file? if so then it is should update the cookies dict instead of replacing it in order to not break the behavior of
self._session.cookies.update(cookies)
There was a problem hiding this comment.
That’s true, so I removed CookieSession.py (it was no longer needed) and updated the cookie-session instance instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i add the "cookie_session" for bypass the captcha and fix some issue with substack changes