fix: handle null property values in PP XML v69+#44
Merged
ma4nn merged 1 commit intoma4nn:masterfrom Apr 14, 2026
Merged
Conversation
Portfolio Performance v69+ can produce properties with empty/null values (e.g. portfolio-chart-details with no text content). The ppxml2db parser was passing None to the DB, which violated the NOT NULL constraint on the property.value column. Coalesce None values to empty string, consistent with how parse_configuration already handles this case.
|
Owner
|
Thanks for your contribution @dgehriger, much appreciated 🙏 |
ma4nn
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Portfolio Performance v69+ can produce XML properties with empty/null text content. For example:
This causes
ppxml2dbto passNoneas the property value to the database, violating theNOT NULLconstraint onproperty.value, resulting in:Users see:
Fix
Coalesce
Noneproperty values to empty string""inhandle_toplevel_properties, consistent with howparse_configurationalready handles this case.Changes
patch_ppxml2db.diff: Updated patch to include the null-coalesce fixtests/fixtures/empty_null_prop.ids.xml: New test fixture with a null property valuetests/data/test_pp_portfolio_builder.py: Added regression test