Conversation
* added bunch of other color themes * change theme name to monokai * rename tokyo-light to tokyo-night-light * update invalid badge theme error message
|
Tip For best results, initiate chat on the files or code changes.
Please let me know what you'd like me to do! |
📝 WalkthroughWalkthroughAdds many new badge color themes, redesigns the detailed SVG badge template to explicit SVG structure, includes repository owner in contribution data, improves JSON error messages, updates documentation and release notes, and adjusts tests and example expectations. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~35 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@docs/badges/BADGE_THEMES.md`:
- Around line 51-62: The table under the text-based theme rows in
BADGE_THEMES.md conflicts with the support note above that claims only the
detailed image is supported; either update that support note to state that
summary and compact variants are now available for "text-based" themes or remove
the Summary/Compact columns and images for rows that have "text-based" to
reflect only Detailed images. Locate the "text-based" rows (e.g., the rows
containing "text-based | monokai", "text-based | solarized-dark", etc.) and make
the documentation consistent by choosing one approach (update the explanatory
note text or strip the extra columns for all "text-based" entries) and ensure
the note wording and the table columns match.
In `@docs/release-notes/v0.3.3.md`:
- Around line 1-4: Update the header lines in the release notes: change the
title string "# Release Notes: v0.3.4" to "# Release Notes: v0.3.3" and correct
the "Release Date: Feb 13, 2025" line to "Release Date: Feb 13, 2026" (leave the
"Codename: Update template design + support 5 new color schemes" text as-is
unless intentionally different); ensure the file content now matches the file
name and PR version.
In `@pkg/ossstats/badge/badgeTemplates/defaults.go`:
- Around line 257-266: There's a stray text node 'class="repo-name"' emitted
after the <text> element which makes the SVG invalid; update the template in
defaults.go so the class attribute is part of the opening <text> tag (or remove
it entirely) — locate the <text ...>{{$r.RepoName}}</text> instance and either
add class="repo-name" inside that opening tag or delete the stray node so no
plain text attribute remains between elements.
🧹 Nitpick comments (1)
pkg/ossstats/badge/badge_test.go (1)
401-423: Include variant in failure output for easier debugging.When a variant fails, the error message doesn’t identify which one. A small tweak improves diagnostics.
♻️ Optional tweak to add variant context
- if err != nil { - t.Fatalf("RenderSVG() unexpected error: %v", err) - } + if err != nil { + t.Fatalf("RenderSVG() unexpected error for variant %v: %v", variant, err) + } ... - if count != tt.wantCount { - t.Errorf("RenderSVG() got %d repos, want %d", count, tt.wantCount) - } + if count != tt.wantCount { + t.Errorf("RenderSVG() got %d repos for variant %v, want %d", count, variant, tt.wantCount) + }
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Tests
Chores