Replace deprecated constructor in TextCharacter #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor TextCharacter(char, TextColor, TextColor, SGR...) is deprecated.
Contributor
|
Looks good to merge. @mabe02 ? |
Contributor
|
I'd probably prefer a change, where the arguments remain on separate lines, and only "new TextCharacter" would change to "TextCharacter.fromCharacter" and the extra [0] at the end. Would make the diff easier to grasp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor has been marked as deprecated, and the use of the fromCharacter() method is recommended by the current API documentation.