User/xavierruttendion/raspidriver#119
Merged
xavierruttendion merged 12 commits intomainfrom Nov 18, 2025
Merged
Conversation
langei
reviewed
Nov 6, 2025
Contributor
langei
left a comment
langei
left a comment
There was a problem hiding this comment.
Looks good! Just a few things to look at. Could you also reference the issue I assigned you in the pr description?
langei
reviewed
Nov 13, 2025
langei
reviewed
Nov 13, 2025
Contributor
langei
left a comment
langei
left a comment
There was a problem hiding this comment.
Looks like we are failing a build for result accumulator tag tests, nothing related to your changes. I think I have a fix - I'll show you in person tomorrow
langei
previously approved these changes
Nov 18, 2025
Contributor
langei
left a comment
langei
left a comment
There was a problem hiding this comment.
Looks good, can you add that one comment to warn users about elevated permissions being required?
langei
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raspi IO driver implementation completed. Has not been tested yet (will try to get that done this week).