Open
Conversation
sokosam
requested review from
BlakeFreer,
CameronBeneteau,
TylerStAmour,
langei and
samparent97
as code owners
BlakeFreer
reviewed
Jun 17, 2025
Contributor
There was a problem hiding this comment.
i don't think we need a tuning menu, the driver should just be able to go
Contributor
There was a problem hiding this comment.
we shouldn't have a separate script. this should be handled entirely in Python.
https://cantools.readthedocs.io/en/latest/
import can
can_bus = can.interface.Bus('vcan0', bustype='socketcan')
data = example_message.encode({'Temperature': 250.1, 'AverageRadius': 3.2, 'Enable': 1})
message = can.Message(arbitration_id=example_message.frame_id, data=data)
can_bus.send(message)Since this is a realtime system, we should send the tuning message periodically instead of just once.
Here's a pattern you could try:
-
Start a thread which sends the Tuning Message every 500 ms.
-
From the UI, when the user clicks "Submit", change the message that the thread is sending.
-
Add a toggle switch to enable/disable sending the message
BlakeFreer
force-pushed
the
live-tuning-raspberry
branch
from
5e5e388 to
57adf1c
Compare
BlakeFreer
force-pushed
the
live-tuning-raspberry
branch
from
57adf1c to
8778b55
Compare
commit 5e5e388 Author: sokosam <samuelshiwork@gmail.com> Date: Sat Jun 14 22:19:06 2025 -0400 dashboard tuning interface commit e5f995e Author: sokosam <samuelshiwork@gmail.com> Date: Sat Jun 7 14:44:41 2025 -0400 change states commit 4137d82 Author: sokosam <samuelshiwork@gmail.com> Date: Sat Jun 7 14:33:25 2025 -0400 dashboard changes commit 82aed62 Author: Samuel Shi <samuelshiwork@gmail.com> Date: Wed May 7 13:59:04 2025 -0400 tuning
BlakeFreer
force-pushed
the
live-tuning-raspberry
branch
from
8778b55 to
2ce04ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.