Get Filament diameter from extruder settings#5
Open
the-snowwhite wants to merge 1 commit intomachinekoder:masterfrom
Open
Get Filament diameter from extruder settings#5the-snowwhite wants to merge 1 commit intomachinekoder:masterfrom
the-snowwhite wants to merge 1 commit intomachinekoder:masterfrom
Conversation
Signed-off-by: Michael Brown <producer@holotronic.dk>
Author
|
@machinekoder is this of interest ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Brown producer@holotronic.dk
This seems to be the official place to commit this fix for the Cura NGCWriter plugin
The filament diameter was hardcoded to 1.75mm in the plugin, making it not possible to print
with 3mm filament without file editing.
This PR fetches the filament diameter more correctly from the printer extruder settings dialog.