fix(pg-template): omit PkColumn(pk int64) method in *SelectSQL#53
Merged
fix(pg-template): omit PkColumn(pk int64) method in *SelectSQL#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the SQL query generation for PostgreSQL and MySQL within the
_exampledirectory. The main focus is on removing unnecessary methods and refining template conditions.Refinement of SQL query generation:
PkColumnmethod was removed because PostgreSQL's implementation does not useLastInsertIdto retrieve the inserted row unlike MySQL. SinceLastInsertIdreturns an int64, thePkColumnmethod was needed for MySQL; however, PostgreSQL usesRETURNINGand therefore does not require thePkColumnmethod._example/postgresql/accounts.gen.go: Removed thePkColumnmethod from theaccountSelectSQLstruct._example/postgresql/groups.gen.go: Removed thePkColumnmethod from thegroupSelectSQLstruct._example/postgresql/identities.gen.go: Removed thePkColumnmethod from theidentitySelectSQLstruct.Template condition improvements:
template/select_column.tmpl: Updated the condition to generate thePkColumnmethod only for MySQL by adding a check for the dialect.