Open
Conversation
macmv
requested changes
Jul 22, 2025
Owner
macmv
left a comment
macmv
left a comment
There was a problem hiding this comment.
concepts look good. needs a couple changes, and formatting (run cargo fmt)
Comment on lines
+28
to
+38
| pub pink_orchid: BlockState, | ||
| pub passion_flower: BlockState, | ||
| pub heliconia: BlockState, | ||
| pub pink_heart: BlockState, | ||
| pub torch_ginger: BlockState, | ||
| pub orchidaceae: BlockState, | ||
| pub ipomoea: BlockState, | ||
| pub bromeliads: BlockState, | ||
| pub ficus_elastica: BlockState, | ||
| pub yellow_jungle_rose: BlockState, | ||
| pub bird_of_paradise: BlockState, |
Owner
There was a problem hiding this comment.
you don't need these. just use the block![] macro when creating the flower_array directly.
Comment on lines
+61
to
+75
| let bottoms = vec![ | ||
| vec!["-ll--", "-lll-", "-lcll", "-lll-", "-----"], // uses top 1 | ||
| vec!["--ll-", "-llll", "-lcll", "-lll-", "-----"], // uses top 2 | ||
| vec!["--l--", "-llll", "-lcll", "-lll-", "-----"], // uses top 1 | ||
| vec!["-----", "-lll-", "-lcl-", "-lll-", "-----"], // uses top 3 | ||
| vec!["-ll--", "-ll--", "-lcl-", "--ll-", "-----"], // uses top 1 | ||
| vec!["--l--", "-lll-", "-lcl-", "-ll--", "-----"], // uses top 4 | ||
| ]; | ||
|
|
||
| let tops = vec![ | ||
| vec!["-l-", "lcl", "-l-"], // top 1 | ||
| vec!["-ll", "lcl", "-l-"], // top 2 | ||
| vec!["-l-", "lcl", "ll-"], // top 3 | ||
| vec!["-l-", "lc-", "-l-"], // top 4 | ||
| ]; |
Owner
There was a problem hiding this comment.
use arrays, not vec!. no need to make a vector for these, as they're constant.
| @@ -0,0 +1,486 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| @@ -0,0 +1,4382 @@ | |||
| # This file is automatically @generated by Cargo. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the finished jungle biomes