Fixed setState issue in MacosPulldownButton#585
Merged
GroovinChip merged 1 commit intomacosui:devfrom Oct 13, 2025
Merged
Conversation
Fix setState() called after dispose in MacosPulldownButton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Reopened PR
This replaces a previous PR that was closed due to a branch issue.
Reopening with a clean branch and the same fix applied.
🧩 Fix: avoid calling setState after dispose in MacosPulldownButton
When I used
MacosPulldownButton, this error appeared during tests:It happened because
setStatewas called inside thenavigator.push(...).then(...)callback after the widget was already disposed.I fixed it by adding a
mountedcheck before callingsetState:Thanks for your patience, I’ll be happy to make any additional changes if needed.