Skip to content

py-jaraco.context: add missing dependency to py-backports.tarfile for python < 3.12 #28542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

someuser12
Copy link
Contributor

@someuser12 someuser12 commented May 25, 2025

Description

py-jaraco.context needs py-backports.tarfile for Python < 3.12 (see https://github.com/jaraco/jaraco.context/blob/main/pyproject.toml), otherwise it fails with a message like:

File /opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/jaraco/context/__init__.py, line 19, in <module>
from backports import tarfile
ModuleNotFoundError: No module named 'backports'

This PR adds a port for py-backports.tarfile and explicits the dependency of py-jaraco.context to it.

Type(s)
  • [x ] bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.10 20G1427 x86_64
Xcode 12.4 12D4e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@reneeotten for port py-jaraco.context.

@macportsbot macportsbot added type: submission maintainer: open Affects an openmaintainer port labels May 25, 2025
@someuser12 someuser12 force-pushed the py-jaraco.context branch from fd08988 to 5473bcc Compare May 25, 2025 23:37
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @someuser12 ! Please address the one review comment and I'll happily merge this.

@someuser12 someuser12 force-pushed the py-jaraco.context branch from 5473bcc to 89eed93 Compare May 26, 2025 08:22
@reneeotten reneeotten merged commit f0862bd into macports:master May 27, 2025
2 of 3 checks passed
@someuser12 someuser12 deleted the py-jaraco.context branch May 27, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: submission
Development

Successfully merging this pull request may close these issues.

3 participants