nettatalk4: update to version 4.2.3

[trodemaster]

Description

Update to version 4.2.3

Type(s)

Tested on

macOS 15.5 24F74 x86_64
Command Line Tools 16.3.0.0.1.1742442376

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[reneeotten]

@trodemaster there are CI failures with the message:
meson.build:2321:16: ERROR: Include dir /opt/homebrew/include does not exist.

can you please take a look at that; if there are any hardcoded mentions of Homebrew in the build script these should probably be removed.

[rdmark]

Netatalk maintainer here. :)

@reneeotten Is there by any chance an /opt/homebrew dir present on those MacPorts CI systems? What the netatalk meson build scripts do, is to check for the existence of a /opt/homebrew dir to determine whether Homebrew is installed or not, and if found add /opt/homebrew/include to the list of include dirs.

This is the only plausible explanation I can offer right now.

That said, I'm going to go ahead and also add a check for the existence of /opt/homebrew/include before attempting to access it in meson in the next release version, so preempt this error.

[reneeotten]

Netatalk maintainer here. :)

@reneeotten Is there by any chance an /opt/homebrew dir present on those MacPorts CI systems? What the netatalk meson build scripts do, is to check for the existence of a /opt/homebrew dir to determine whether Homebrew is installed or not, and if found add /opt/homebrew/include to the list of include dirs.

This is the only plausible explanation I can offer right now.

That said, I'm going to go ahead and also add a check for the existence of /opt/homebrew/include before attempting to access it in meson in the next release version, so preempt this error.

Not sure whether GitHub CI automatically installs Homebrew. In any case, end-user might have it installed (although we recommend against it) and thus even it it is present MacPorts' build should ignore it.

[rdmark]

I'm preparing a new upstream bugfix release that should address this issue.

[rdmark]

v4.2.4 is now available, which no more default homebrew lib and include paths for the compiler

https://github.com/Netatalk/netatalk/releases/tag/netatalk-4-2-4

[rdmark]

My apologies, it turns out I introduced another bug in the meson scripts when building on macOS without Homebrew.

The patch in this PR should address the issue. Netatalk/netatalk#2203

Is MacPorts able to do downstream hotfix patching for ports?

[trodemaster]

@reneeotten the update is in good shape now! Thanks for the help @rdmark !