Conversation
| description: 'Version tag (e.g., v1.0.0)' | ||
| required: true | ||
| specific_image: | ||
| description: 'Build only this image (leave empty to build all images)' |
There was a problem hiding this comment.
maybe add a list of available images to build individually (if description max size allows it)
| tags: | | ||
| ${{ env.DOCKER_ORGANIZATION }}/${{ matrix.image }}:latest | ||
| ${{ env.DOCKER_ORGANIZATION }}/${{ matrix.image }}:${{ github.event.inputs.version }}-${{ steps.hash.outputs.hash }} | ||
| ghcr.io/${{ github.repository_owner }}/${{ matrix.image }}:latest | ||
| ghcr.io/${{ github.repository_owner }}/${{ matrix.image }}:${{ github.event.inputs.version }}-${{ steps.hash.outputs.hash }} |
| @@ -0,0 +1,71 @@ | |||
| name: "Publish Docker Images" | |||
There was a problem hiding this comment.
just to be aligned with how the worfklow files are named in the madara monorepo, this file can be renamed to task-docker-build-and-publish.yml
| let ( | ||
| repo, | ||
| anvil_version, | ||
| helper_version, |
There was a problem hiding this comment.
can this be named to something like l1_helper or similar that gives an idea of what it is more precisely
There was a problem hiding this comment.
I'm keeping this as helper (general purpose helper image) since it's right now to override the state from the L1 but it will be removed once SNOS version is updated in Orchestrator and this image won't be needed anymore.
| WORKDIR /app | ||
|
|
||
| RUN git clone --recurse-submodules https://github.com/madara-alliance/madara-bootstrapper.git . | ||
| ENV BOOTSTRAPPER_VER="a99088a96a8126d33fef4fabba76a70032e601cf" |
There was a problem hiding this comment.
not sure why this is needed since bootstrapper is in the monorepo now, but maybe add a comment from where this value comes from to give more context
There was a problem hiding this comment.
Changed to main branch now that the 3 projects are there
|
|
||
| override_state: | ||
| image: {{ IMAGE_REPOSITORY }}anvil:${ANVIL_VERSION} | ||
| image: {{ IMAGE_REPOSITORY }}helper:${HELPER_VERSION} |
There was a problem hiding this comment.
Also here you could rename the image, or just maybe update the docs explaining what the helper does
There was a problem hiding this comment.
Changed to main branch now that the 3 projects are there
|
|
||
| RUN echo Cloning madara from branch ${MADARA_VER} | ||
| RUN git clone --branch ${MADARA_VER} --single-branch https://github.com/madara-alliance/madara . && \ | ||
| ENV MADARA_VER="a99088a96a8126d33fef4fabba76a70032e601cf" |
There was a problem hiding this comment.
same as in the orchestrator image, why is this needed?
There was a problem hiding this comment.
Changed to main branch now that the 3 projects are there
2 participants
Use official Foundry image for Anvil service and for deploying mock-verifier contract
Update Madara dockerfile to build from main branch (monorepo)
Update Orchestrator dockerfile to build from main branch (monorepo)
Update Bootstrapper dockerfile to build from monorepo/bootstrapper branch (monorepo)
Add CI script to build and publish all the docker images
Removed old and unused files