getVideoInfo with params and Youtube quotas calculator #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with phpunit latest version (8)
phpunit8 compliancy and getVideoInfo update
… 50 playlists on one channelId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
My first move was to add optionnal params to getVideoInfo and create one tests to go with.
My second move was to add Youtube quota calculation. The goal of this is to calculate the quota used on each api request made dynamically.
A class YoutubeQuotas has been made for it. And I inject a YoutubeQuotas instance in your Youtube class. If this object is set I'm calculating the quota used by the query.
If you have any question, please tell me :)
Thanks you for making this lib (I'm using it everyday) and for reading this :)
Cheers