Bind to click events by default, bind to touch events only if supported#17
Open
sirajea wants to merge 2 commits intomadetech:masterfrom
Open
Bind to click events by default, bind to touch events only if supported#17sirajea wants to merge 2 commits intomadetech:masterfrom
sirajea wants to merge 2 commits intomadetech:masterfrom
Conversation
Because devices can have both a mouse AND a touchscreen. Click wasn't working for these devices. This fixes it because it binds to click events by default and additionally binds to touch events if touch is supported.
Contributor
|
@sirajea thanks for this, I'll check it out later. |
Contributor
|
Would be great if you could apply any change to both the coffeescript too |
…ed (coffeescript)
Author
|
@SebAshton You're welcome. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because devices can have both a mouse AND a touchscreen. Click wasn't working for these devices. This fixes it because it binds to click events by default and additionally binds to touch events if touch is supported.