Update dependencies and improved compatibility for Ruby 2.0 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This may be better to be pulled into a dev branch targeting an eventual new version release. |
I was getting an error when trying to `bundle install` in 1.9.3. Relaxing the version numbers I added fixed it and, and the specs still pass the same on 1.9.3 and 2.0.0.
Member
|
Thanks, I'll be taking a look at this soon. test/spec is an old BDD interface on top of test/unit, which I'm no longer using for current projects. RSpec is great -- it's my current default for new work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes rspec was being used, and that may be an incorrect assumption. Not
sure what test/spec mapped too, but that wasn't available for me locally, so I
had to remove it.
With these changes I can get the project specs to run for my locally using ruby
2.0.0.
All pass expect for two. I have work around fixes to get the last two specs
passing, but not exactly sure why they're failing.
If there was a different test framework being used, there may be an easier way to get
the specs to pass, but this is what I got working with rspec.