fixes for latest blink API #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk94
suggested changes
Dec 28, 2020
lib/blink.js
Outdated
| return reject(new BlinkAuthenticationException(`Authentication problem: ${body.message}`)); | ||
| } | ||
| if (!body.region) { | ||
| if (!valid) { |
There was a problem hiding this comment.
I think this should be
if (!body.valid) { }
because valid is not defined before.
Owner
There was a problem hiding this comment.
Should be still a check for body.region
Author
|
I've made updates for the v5 login which changed the login URL as well as the response data from the blink server. 9f8f99b |
|
Any status on merging this PR? |
Author
|
Ported the latest auth changes from the Python project to the Node version. I brought it closer to the structure of the Python library by adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API changed quite a bit from the prior version. Had to re-arrange a bit to preserve the original node-blink-security functionality.