Fix typings and propTypes for passing ViewProps to ImageSequence#39
Closed
bwindsor wants to merge 12 commits intomadsleejensen:masterfrom
Closed
Fix typings and propTypes for passing ViewProps to ImageSequence#39bwindsor wants to merge 12 commits intomadsleejensen:masterfrom
bwindsor wants to merge 12 commits intomadsleejensen:masterfrom
Conversation
Author
|
Closing because I'm messing around too much on my fork. I'll open another PR once I get myself sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using TypeScript, if you pass a
styleprop toImageSequenceit complains, even though any ViewProp can actually be passed toImageSequence. I have fixed the typings and propTypes.This PR also includes the fix in #38, which is required to prevent crashing if using larger number of images, or if reloading small number of images regularly.