[MNOE-857] Setup divisions when creating a new organization based on …#209
Open
MAhsenArif wants to merge 2 commits intomaestrano:masterfrom
Open
[MNOE-857] Setup divisions when creating a new organization based on …#209MAhsenArif wants to merge 2 commits intomaestrano:masterfrom
MAhsenArif wants to merge 2 commits intomaestrano:masterfrom
Conversation
MAhsenArif
force-pushed
the
auto_assign_staff_division
branch
2 times, most recently
from
f4a5d04 to
6d36585
Compare
MAhsenArif
force-pushed
the
auto_assign_staff_division
branch
from
6d36585 to
216a1cb
Compare
ouranos
requested changes
Jan 30, 2018
Contributor
ouranos
left a comment
ouranos
left a comment
There was a problem hiding this comment.
This feature needs to be gated between the MnoeAdminConfig.isSubTenantEnabled() feature flag.
Otherwise LGTM.
| # List of checked apps | ||
| vm.organization.app_nids = _.map(_.filter(vm.marketplace.apps, {checked: true}), 'nid') if MnoeAdminConfig.isAppManagementEnabled() | ||
|
|
||
| vm.organization.sub_tenant_ids = Object.keys vm.selectedSubTenants |
Contributor
There was a problem hiding this comment.
Object.keys(vm.selectedSubTenants)
MAhsenArif
force-pushed
the
auto_assign_staff_division
branch
from
41145b3 to
6a56970
Compare
Contributor
Author
|
@ouranos Encapsulated logic in |
ouranos
approved these changes
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…user role