feat(search)!: add search vectors for all supported languages #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dargmuesli
requested changes
Jun 19, 2025
| @@ -0,0 +1,30 @@ | |||
| BEGIN; | |||
|
|
|||
| CREATE TABLE vibetype.event_search_vector ( | |||
Member
There was a problem hiding this comment.
Introducing a new table makes the availability of search vectors more flexible which can be a good or bad thing. Right now I'd like to rely on search vectors to be available / not null for all supported languages to prevent confusion when data is missing partly.
Member
|
Make sure the changes base on |
A new table `vibetype.event_search_vector` to accommodate search vectors for every supported language, so each event will have multiple search vectors.
sthelemann
force-pushed
the
feat/search/multi-language
branch
from
8a50137 to
b5a3b43
Compare
Function `event_search` was modified to align with the new 1-to-many relationship between events and text search vectors. Tests were added.
sthelemann
force-pushed
the
feat/search/multi-language
branch
from
b515bda to
74a5a9a
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new table
vibetype.event_search_vectorto accommodate search vectors for every supported language, so each event will have multiple search vectors.