Skip to content

Fixed bug with map field stringifying#43

Open
andrewosh wants to merge 1 commit intomafintosh:masterfrom
andrewosh:map-stringify-fix
Open

Fixed bug with map field stringifying#43
andrewosh wants to merge 1 commit intomafintosh:masterfrom
andrewosh:map-stringify-fix

Conversation

@andrewosh
Copy link
Copy Markdown

@andrewosh andrewosh commented Jul 25, 2018

Map fields are currently stringified with an extra map token, which is invalid syntax, i.e.:

message Data {
  map<string, string> something = 1;
}

When parsed + stringified produces:

message Data {
  map<string, string> map something = 1;
}

This PR fixes stringify for map fields, and includes a test that fails on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant