Allowing protobuf version and import statements in .proto files to use single quotes in addition to double quotes#44
Open
PresNCode wants to merge 1 commit intomafintosh:masterfrom
Open
Conversation
…e single quotes instead of only double quotes (e.g. allow _version = 'proto2';_, which is supported by the google javascript protoc compiler but not by this package
|
I would love to see this merged. Seems like a low-risk change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing protobuf version and import statements in .proto files to use single single quotes instead of only double quotes (e.g. allow version = 'proto2';, which is supported by the google javascript protoc compiler but not by this package). This is just a QoL improvement, and should not have a functional impact- it just lets users who have .proto files using single quotes where allowed by the protoc compiler to not have to change them in order to use this package.