Fully qualified import modifiers#67
Open
martinheidegger wants to merge 4 commits intomafintosh:masterfrom
Open
Fully qualified import modifiers#67martinheidegger wants to merge 4 commits intomafintosh:masterfrom
martinheidegger wants to merge 4 commits intomafintosh:masterfrom
Conversation
martinheidegger
force-pushed
the
import-modifiers
branch
from
a52c120 to
bcba046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Based on #65
Unlike the implementation presented in #66, this PR offers full support for modifiers in imports. Unfortunately this is a breaking change, requiring a major version release, so maybe first merge #66, release and then merge this?