Fixed parse.js to prevent Prototype Pollution#70
Open
MorielHarush wants to merge 1 commit intomafintosh:masterfrom
Open
Fixed parse.js to prevent Prototype Pollution#70MorielHarush wants to merge 1 commit intomafintosh:masterfrom
MorielHarush wants to merge 1 commit intomafintosh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a Prototype Pollution vulnerability in the parser. The current implementation allows an attacker to bypass security boundaries by using the proto key within a .proto file (specifically in field options).
The Vulnerability:
When parsing field options like [(foo).bar = "value"], the parser uses reduce to traverse the path. If an attacker provides (proto) as a path component, the parser accesses the global Object.prototype. This allows the attacker to inject properties into every object in the Node.js process.
Proof of Concept (PoC):
Proposed Changes:
Null Prototypes: Switched from plain object literals {} to Object.create(null) for all data-holding structures (options, schema, messages, etc.).
Inheritance Protection: By using null-prototype objects, the proto key is treated as a regular property and does not trigger inheritance traversal.
Impact:
Prevents attackers from causing Denial of Service (DoS) or potentially Remote Code Execution (RCE) by polluting the global environment of applications that parse untrusted .proto files or Authentication Bypass.