Open
Conversation
|
this doesn't seem to implement the async iterator things. neither does |
mafintosh
reviewed
Jun 20, 2023
index.d.ts
Outdated
| entry(header: HeaderForPack, callback?: (error?: Error) => void): Sink | ||
| entry( | ||
| header: HeaderForPack, | ||
| buffer: string | Buffer, |
Author
There was a problem hiding this comment.
Yes. When buffer is not provided, the signature would be the one on line 23.
Author
Thanks for reminding. Now the updated version includes the missing async iterator. @mafintosh Please check again :) |
|
Great work @alvis 👍 I was about to start defining the types myself as the |
Author
|
@mafintosh let's do a review and let me know if there's anything missing 😎 |
|
any updates on this PR, any chance it'll be merged soon ? |
a-eid
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #97