Try adding messages to elements #247
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmales
reviewed
Dec 7, 2025
| } | ||
|
|
||
| pcf::IndiElement elem = pcf::IndiElement(it->first, pcf::IndiElement::Off); | ||
| if (it->second->message() != "") { |
Member
There was a problem hiding this comment.
I know that libMagAOX was checking "", but I've since figured out that libcommon isn't doing anything different with defaults. it should be fine to just add every message.
Member
|
converting to draft so it doesn't get merged |
Member
|
I fixed this with #277, but your code improvements might still be worth pushing. Otherwise we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, running this makes labrules stop responding to INDI requests. No dead threads or exceptions I could find after added some more debugging info.