Open
Conversation
PiperOrigin-RevId: 460754854
copybara-service
bot
force-pushed
the
test_460754854
branch
from
88644c4 to
7c104c2
Compare
|
looks good to me. only thing I notice is that |
cyrusasfa
reviewed
Jul 22, 2022
| tf.io.FixedLenSequenceFeature([], | ||
| dtype=tf.float32, | ||
| allow_missing=True), | ||
| 'sequence': |
There was a problem hiding this comment.
how is sequence extracted from the source URMP dataset? what is it?
There was a problem hiding this comment.
I figured you can just create a NoteSequence using URMP's notes files
cyrusasfa
suggested changes
Jul 27, 2022
There was a problem hiding this comment.
One bug to fix.
Generally it would be helpful to have a script that extracts correctly formatted necessary features from the raw URMP dataset and dumps to TFRecord. I've done this and can make a new PR. Alternatively the 48 kHz tfrecord without the metadata and DDSP features could be uploaded somewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open source URMP dataset pipeline