Skip to content

Bugfix/issue4 better rejected url output #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/issue4 better rejected url output #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a09eb9b
fix usage of CacheRouteInterfaceFactory
Dec 20, 2019
e5b4353
close #5 with better logging output
Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Console/Command/CacheWarmup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

namespace Firegento\CacheWarmup\Console\Command;

use GuzzleHttp\Client;
use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Pool;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\RequestOptions;
use League\CLImate\CLImate;
use Magento\UrlRewrite\Model\ResourceModel\UrlRewriteCollection;
Expand Down Expand Up @@ -129,11 +133,11 @@ private function getPool(Client $client, callable $requests, OutputInterface $ou
{
return new Pool($client, $requests(), [
'concurrency' => $this->maxConcurrentRequests,
'fulfilled' => function ($response, $index) use ($output) {
$output->writeln("Successful: " . $index);
'fulfilled' => function (Response $response, $index) use ($client, $output) {
$output->writeln('Successful: ' . $index);
},
'rejected' => function ($reason, $index) use ($output) {
$output->writeln("Rejected: " . $index);
'rejected' => function (RequestException $reason, $index) use ($client, $output) {
$output->writeln('Rejected: ' . $reason->getRequest()->getUri());
},
]);
}
Expand Down
1 change: 1 addition & 0 deletions Model/Route/Query/GetById.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Firegento\CacheWarmup\Model\Route\Query;

use Firegento\CacheWarmup\Api\Data\CacheRouteInterface;
use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory;
use Magento\Framework\Api\SimpleDataObjectConverter;
use Magento\Framework\App\ResourceConnection;

Expand Down
1 change: 1 addition & 0 deletions Model/Route/Query/GetByRoute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Firegento\CacheWarmup\Model\Route\Query;

use Firegento\CacheWarmup\Api\Data\CacheRouteInterface;
use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory;
use Magento\Framework\Api\SimpleDataObjectConverter;
use Magento\Framework\App\ResourceConnection;

Expand Down
1 change: 1 addition & 0 deletions Model/Route/Query/SaveRoute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Firegento\CacheWarmup\Model\Route\Query;

use Firegento\CacheWarmup\Api\Data\CacheRouteInterface;
use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory;
use Magento\Framework\App\ResourceConnection;

class SaveRoute
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"guzzlehttp/guzzle": "~6.2"
},
"type": "magento2-module",
"version": "0.1.0",
"version": "0.1.1",
"autoload": {
"files": [
"registration.php"
Expand Down