add app/design path #2527
Merged
add app/design path #2527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (magentoPathUrl != null) { | ||
| if (magentoToFolders == null) { | ||
| magentoToFolders = List.of( | ||
| magentoPathUrl | ||
| magentoPathUrl, | ||
| magentoDesignUrl | ||
| ); | ||
| } else { | ||
| magentoToFolders.add( |
There was a problem hiding this comment.
magentoPathUrl,
magentoDesignUrl
please add here to
Refactored logic to handle Magento folder paths more robustly, ensuring design paths are added without overwriting existing ones. Updated plugin version to 2025.1.1 and added relevant changelog entry for bug fix magento#2527. Incremental version changes made in plugin metadata and build properties.
|
would be nice if this fix is released asap |
You can install the patched version manually by uploading it to PHPStorm |
Modified the `click()` method in `SharedSteps.kt` to include specific point coordinates, ensuring accurate interaction with the 'New Project' button. This change prevents potential misclicks and improves test reliability.
|
@webcreative24 could you please sign CLA |
done |
Refactored utility classes to improve structure and clarity by adding proper encapsulation and final declarations. Fixed group ID inconsistencies in plugin XML to align with intended usage. Re-enabled commented-out steps in `uitests.yml` for capturing and uploading artifacts on test failures.
Registered PS.MarkRootGroup to correctly add the action, addressing a missing functionality. Changed test artifact capture condition from Windows to Ubuntu for consistency with the testing environment.
This ensures no lingering Chrome or Chromium processes interfere with test execution, improving reliability. The step is added both before and during test execution for Ubuntu environments.
The step to kill Chrome processes was unnecessary and has been removed to simplify the workflow. This change reduces redundancy and ensures the workflow remains focused on essential tasks.
Ensure browsers are properly closed in all scenarios by invoking `closeBrowser()` in the appropriate locations. Additionally, include termination of Chrome processes on Linux systems for better cleanup.
Ensure browsers are properly closed in all scenarios by invoking `closeBrowser()` in the appropriate locations. Additionally, include termination of Chrome processes on Linux systems for better cleanup.
Commented out steps for capturing and uploading test artifacts in the UI test workflow. This change likely aims to streamline the workflow and reduce unnecessary artifact handling during test failures.
VitaliyBoyko
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "app/design" as magento editable folder