ACP2E-3660: REST endpoint Product Import Json not validate the mandatory fields

Author: aplapana

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

@@ -379,11 +379,11 @@ public function getInvalidAttribute()
     }
 
     /**
-     * Is valid attributes
+     * Validate attributes against configured properties
      *
      * @return array
      */
-    protected function isValidAttributes()
+    private function validateAttributes(): array
     {
         $this->_clearMessages();
         $this->setInvalidAttribute(null);
@@ -412,21 +412,52 @@ protected function isValidAttributes()
         return $attributeValidationResult;
     }
 
+    /**
+     * Is valid attributes
+     *
+     * @return bool
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     */
+    protected function isValidAttributes()
+    {
+        $this->_clearMessages();
+        $this->setInvalidAttribute(null);
+        if (!isset($this->_rowData['product_type'])) {
+            return false;
+        }
+        $entityTypeModel = $this->context->retrieveProductTypeByName($this->_rowData['product_type']);
+        if ($entityTypeModel) {
+            foreach ($this->_rowData as $attrCode => $attrValue) {
+                $attrParams = $entityTypeModel->retrieveAttributeFromCache($attrCode);
+                if ($attrCode === Product::COL_CATEGORY && $attrValue) {
+                    $this->isCategoriesValid($attrValue);
+                } elseif ($attrParams) {
+                    $this->isAttributeValid($attrCode, $attrParams, $this->_rowData);
+                }
+            }
+            if ($this->getMessages()) {
+                return false;
+            }
+        }
+        return true;
+    }
+
     /**
      * @inheritdoc
      */
     public function isValid($value)
     {
         $this->_rowData = $value;
         $this->_clearMessages();
-        $validatedAttributes = $this->isValidAttributes();
+        $validatedAttributes = $this->validateAttributes();
         /** @var Product\Validator\AbstractImportValidator $validator */
         foreach ($this->validators as $validator) {
             if (!$validator->isValid($value)) {
                 $this->_addMessages($validator->getMessages());
             } else {
                 //prioritize specialized validation
                 if ($validator->getFieldName() &&
+                    isset($validatedAttributes['attributes']) &&
                     $validatedAttributes['attributes'][$validator->getFieldName()] === false
                 ) {
                     $validatedAttributes['attributes'][$validator->getFieldName()] = true;

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/AbstractTypeTest.php

@@ -1,8 +1,8 @@
 <?php declare(strict_types=1);
 
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2015 Adobe
+ * All Rights Reserved.
  */
 namespace Magento\CatalogImportExport\Test\Unit\Model\Import\Product\Type;