Skip to content

Conversation

SilinMykola
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Fixes Remove old code for php versions we no longer support #39362

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Sep 23, 2025

Hi @SilinMykola. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated code that was specifically written to handle compatibility with HHVM (Hip Hop Virtual Machine) and older PHP versions that are no longer supported.

  • Removes HHVM-specific test skips and workarounds across numerous test files
  • Updates hash algorithm default from conditional to always use 'xxh128'
  • Removes PHP version checks and HHVM references from configuration files

Reviewed Changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pub/.htaccess Updates comment to remove HHVM reference
lib/internal/Magento/Framework/Stdlib/DateTime/DateTimeFormatter.php Simplifies initialization to always use IntlFormatObject
lib/internal/Magento/Framework/Jwt/JwkFactory.php Removes resource cleanup for older PHP versions
app/code/Magento/CatalogImportExport/Model/Import/Product.php Updates hash algorithm to always use xxh128
Multiple test files Removes HHVM-specific test skips and compatibility checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

->method('execute')
->willThrowException(new \PDOException('test message'));
$this->setQueryStringForPdoStmtMock($query);
$this->pdoStatementMock->queryString = $query;
Copy link
Preview

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Direct property assignment to a mock object might fail if queryString is not a defined property on the mock. Consider using the expects() method or ensuring the mock is properly configured to accept this property.

Suggested change
$this->pdoStatementMock->queryString = $query;
$this->pdoStatementMock->expects($this->any())
->method('__get')
->with('queryString')
->willReturn($query);

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SilinMykola, please double-check this place, most likely the fix is needed here

@orlangur
Copy link
Contributor

Nice catch! Wanted to remove HHVM-related stuff ages ago :)

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 30, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Remove old code for php versions we no longer support
4 participants