Fix admin got auto logged out when displaying large number of product reviews #40227

imran9935 · 2025-10-14T10:13:56Z

Fixed Issues

Fixes : Admin got auto logged out when product reviews data is more than 28,000 at Marketing > All Reviews

Description (*)

Admin gets automatically logged out when opening the 'All Reviews' section in Marketing. This occurs for products with more than 28,000 reviews, as the system cannot handle such a large volume at once.

Manual testing scenarios (*)

Add products reviews with more than 28,000 reviews
Log in to the magento admin panel and navigate to Marketing > User Content > All Reviews.
Try to navigate or refresh the All Reviews page.
Observe that the admin is automatically logged out.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2025-10-14T10:13:59Z

Hi @imran9935. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

lbajsarowicz · 2025-10-21T19:48:35Z

@magento run all tests

engcom-Hotel · 2025-10-27T11:24:43Z

@magento run all tests

engcom-Hotel

Hello @imran9935,

Thank you for your contribution!

Please fix the the failed failed static and integration tests. and have a look into the below review comment.

engcom-Hotel · 2025-10-29T10:43:07Z

app/code/Magento/Review/Helper/Action/Pager.php

+     * @return int|false
     */
-    protected function _findItemPositionByValue($value)
+    private function getRelativeReviewId($id, $operator, $order)


Add return type for this method

engcom-Hotel · 2025-10-29T10:46:03Z

app/code/Magento/Review/Model/ResourceModel/Review/Product/Collection.php

-     *
-     * @return array
-     */
-    public function getResultingIds()


Removing this method could be backward incompatible change.

engcom-Hotel · 2025-11-11T06:49:52Z

Hello @imran9935,

Gentle reminder for this PR — please let us know when it’s ready for review.

Thank you

imran9935 · 2025-11-20T13:31:30Z

Hello @engcom-Hotel,
I have made the requested code changes, and also updated the code to resolve the failed static and integration tests.

Thank you

imran9935 · 2025-11-21T06:59:08Z

@magento run all tests

engcom-Hotel

Hello @imran9935,

Thank you for your contribution!

We can see various BiC changes in this PR, please fix those. You can refer to the below documents for reference:

engcom-Hotel · 2025-11-21T10:19:02Z

app/code/Magento/Review/Block/Adminhtml/Grid.php

-     *
-     * @return \Magento\Backend\Block\Widget\Grid
-     */
-    protected function _afterLoadCollection()


Removing this method could backward incompatible change, third-party extensions may override this method.

engcom-Hotel · 2025-11-21T10:22:29Z

app/code/Magento/Review/Helper/Action/Pager.php

    public function __construct(
        \Magento\Framework\App\Helper\Context $context,
-        \Magento\Backend\Model\Session $backendSession
+        CollectionFactory $reviewCollectionFactory


Use ObjectManager to initialise this, and make it null by default

engcom-Hotel · 2025-11-21T10:26:17Z

app/code/Magento/Review/Helper/Action/Pager.php

Various methods has been removed from here, this could be backward incompatible change.

imran9935 · 2025-11-24T07:16:13Z

@engcom-Hotel I have added methods to maintain backward compatibility

engcom-Hotel · 2025-11-24T10:06:08Z

@magento run all tests

imran9935 · 2025-11-24T12:11:48Z

@magento run all tests

engcom-Hotel

Hello @imran9935,

Please refer to the below review comments.

Thank you

engcom-Hotel · 2025-11-24T12:04:07Z

app/code/Magento/Review/Helper/Action/Pager.php

+     * @return int|false
     */
-    public function getNextItemId($id)
+    public function getNextItemId($id): int|false


recommend to make it bool again

engcom-Hotel · 2025-11-24T12:05:10Z

app/code/Magento/Review/Helper/Action/Pager.php

+     * @return int|false
     */
-    public function getPreviousItemId($id)
+    public function getPreviousItemId($id): int|false


recommend to make it bool

engcom-Hotel · 2025-11-24T12:45:37Z

app/code/Magento/Review/Block/Adminhtml/Edit.php


        /** @var $actionPager \Magento\Review\Helper\Action\Pager */
        $actionPager = $this->_reviewActionPager;
-        $actionPager->setStorageId('reviews');


Removing $actionPager->setStorageId('reviews') breaks the pagination API contract.

If setStorageId() is never called, then _getStorageKey() in Pager.php throws exception:

engcom-Hotel · 2025-11-24T12:47:38Z

app/code/Magento/Review/Model/ResourceModel/Review/Product/Collection.php

     *
     * @return array
+     * @deprecated This method is not being used to fetch ids anymore.We use it only to support backward compatibility
+     * @see Pager


Reference the new method in a @see tag as a recommended replacement.

engcom-Hotel · 2025-11-24T12:50:08Z

app/code/Magento/Review/Block/Adminhtml/Grid.php

-        $actionPager = $this->_reviewActionPager;
-        $actionPager->setStorageId('reviews');
-        $actionPager->setItems($this->getCollection()->getResultingIds());


Removing these lines might breaks prev/next functionality unless replaced with alternative.

@engcom-Hotel I have made the other changes, for prev/next functionality, I have handled it in the Pager.php, please look at getPreviousItemId and getNextItemId methods.

engcom-Hotel · 2025-11-25T06:19:55Z

@magento run all tests

imran9935 · 2025-11-25T10:10:18Z

@magento run all tests

engcom-Hotel

Hello @imran9935,

Please fix the failed static tests and also look into the below review comment.

Thank you

engcom-Hotel · 2025-11-25T12:54:18Z

app/code/Magento/Review/Helper/Action/Pager.php

 class Pager extends \Magento\Framework\App\Helper\AbstractHelper
 {
-    const STORAGE_PREFIX = 'search_result_ids';
+    protected const STORAGE_PREFIX = 'search_result_ids';


Any specific reason to change constant visibility from public to protected?

Fix admin auto-logout when displaying large number of product reviews

6e8aa57

Merge branch '2.4-develop' into review-grid-logout

5af53da

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 14, 2025

ct-prd-projects-boards-automation bot added this to Pull Requests Dashboard Oct 14, 2025

github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Oct 14, 2025

ct-prd-projects-boards-automation bot added Progress: pending review labels Oct 14, 2025

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Oct 15, 2025

ct-prd-projects-boards-automation bot added this to Community Dashboard Oct 15, 2025

ct-prd-projects-boards-automation bot moved this to Pending Review in Community Dashboard Oct 15, 2025

ct-prd-projects-boards-automation bot removed this from Pull Requests Dashboard Oct 15, 2025

Merge branch '2.4-develop' into review-grid-logout

1840736

engcom-Hotel self-requested a review October 29, 2025 10:40

ct-prd-projects-boards-automation bot added the Progress: review label Oct 29, 2025

engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Oct 29, 2025

ct-prd-projects-boards-automation bot removed the Progress: pending review label Oct 29, 2025

engcom-Hotel requested changes Oct 29, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Oct 29, 2025

ct-prd-projects-boards-automation bot added Progress: needs update and removed Progress: review labels Oct 29, 2025

imran9935 and others added 2 commits November 20, 2025 18:43

Merge branch 'magento:2.4-develop' into review-grid-logout

7d96d70

Fixed failed static and integration tests

4ab76c2

imran9935 added 2 commits November 21, 2025 11:21

Fixed failed static test

ed08e62

Improved doc block

73e7edc

engcom-Hotel moved this from Changes Requested to Review in Progress in Community Dashboard Nov 21, 2025

ct-prd-projects-boards-automation bot added Progress: review and removed Progress: needs update labels Nov 21, 2025

engcom-Hotel requested changes Nov 21, 2025

View reviewed changes

Added methods to support backward compatibility

39502f5

Merge branch '2.4-develop' into review-grid-logout

ab55653

Fixedfailed static test

1e122b1

engcom-Hotel requested changes Nov 24, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Nov 24, 2025

ct-prd-projects-boards-automation bot added Progress: needs update and removed Progress: review labels Nov 24, 2025

imran9935 and others added 2 commits November 24, 2025 18:46

Updated return type for methods

922e107

Merge branch '2.4-develop' into review-grid-logout

441bf69

engcom-Hotel moved this from Changes Requested to Pending Review in Community Dashboard Nov 25, 2025

ct-prd-projects-boards-automation bot added Progress: pending review Progress: review and removed Progress: needs update Progress: pending review labels Nov 25, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Nov 25, 2025

imran9935 added 2 commits November 25, 2025 14:47

Fixed failed static test

49b25bc

Removed extra space

e1220b3

engcom-Hotel requested changes Nov 25, 2025

View reviewed changes

engcom-Hotel added Progress: needs update and removed Progress: review labels Nov 25, 2025

ct-prd-projects-boards-automation bot moved this from Review in Progress to Changes Requested in Community Dashboard Nov 25, 2025

Fix admin got auto logged out when displaying large number of product reviews #40227

Are you sure you want to change the base?

Fix admin got auto logged out when displaying large number of product reviews #40227

Conversation

imran9935 commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues

Description (*)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 14, 2025

Uh oh!

lbajsarowicz commented Oct 21, 2025

Uh oh!

engcom-Hotel commented Oct 27, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Nov 11, 2025

Uh oh!

imran9935 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imran9935 commented Nov 21, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imran9935 commented Nov 24, 2025

Uh oh!

engcom-Hotel commented Nov 24, 2025

Uh oh!

imran9935 commented Nov 24, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imran9935 Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Nov 25, 2025

Uh oh!

imran9935 commented Nov 25, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

imran9935 commented Oct 14, 2025 •

edited

Loading

imran9935 commented Nov 20, 2025 •

edited

Loading

imran9935 Nov 24, 2025 •

edited

Loading