Skip to content

add: add korean language support #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessehj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add: add korean language support #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { ComponentType } from 'react';
import { ViewStyle, TextStyle } from 'react-native';

export type LocaleType = 'es' | 'en' | 'fr' | 'br' | 'zh';
export type LocaleType = 'es' | 'en' | 'fr' | 'br' | 'zh' | 'ko';

interface DayTheme {
activeDayColor?: string;
Expand Down
17 changes: 17 additions & 0 deletions src/utils/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,21 @@ export function getMonthNames(locale: LocaleType) {
'Novembro',
'Dezembro',
];
case 'ko':
return [
'1월',
'2월',
'3월',
'4월',
'5월',
'6월',
'7월',
'8월',
'9월',
'10월',
'11월',
'12월'
];
default:
return [
'January',
Expand Down Expand Up @@ -145,6 +160,8 @@ function getWeekdayNames(locale: LocaleType) {
return ['Dom', 'Seg', 'Ter', 'Qua', 'Qui', 'Sex', 'Sab'];
case 'zh':
return ['日', '一', '二', '三', '四', '五', '六'];
case 'ko':
return ['일', '월', '화', '수', '목', '금', '토'];
Comment on lines +163 to +164
Copy link
Owner

@maggialejandro maggialejandro Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, are these translation correct?
These are the translations I found, please correct me if I'm wrong

Monday -월요일
Tuesday - 화요일
Wednesday - 수요일
Thursday - 목요일
Friday - 금요일
​Saturday - 토요일
Sunday - 일요일

Copy link
Author

@jessehj jessehj Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are correct.
What I wrote is an abbreviation.
I'm affraid there is little space. but it doesn't matter.
I will follow your judgement
Thanks for the quick response!

default:
return ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'];
}
Expand Down