fix: passing accessible=false to Wrapper #186
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current codebase, an
accessible=falseprop won't be passed on toWrapper, because of the lineThis will always set
Wrapper.accessibleto true.This PR changes this such that
accessible=falsewill be passed on.Background: the current implementation does not seem to be testable under maestro.dev - there are other RN components that have the same problem, see for example here. One of the possible solutions is to set
accessible=falseon the container of the overlay / toast.