Skip to content

Conversation

@yolpsoftware
Copy link

@yolpsoftware yolpsoftware commented May 11, 2025

In the current codebase, an accessible=false prop won't be passed on to Wrapper, because of the line

accessible={props.accessible ? props.accessible : true}

This will always set Wrapper.accessible to true.

This PR changes this such that accessible=false will be passed on.

Background: the current implementation does not seem to be testable under maestro.dev - there are other RN components that have the same problem, see for example here. One of the possible solutions is to set accessible=false on the container of the overlay / toast.

@sunnylqm
Copy link
Collaborator

i am not familar with this code, but why not simply accessible={props.accessible}?

@yolpsoftware
Copy link
Author

i am not familar with this code, but why not simply accessible={props.accessible}?

Fine with me. Not sure why there was a condition in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants