Skip to content

Fixed duration set to zero bug #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed duration set to zero bug #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa9de96
added fix for "cannot read from setNativeProps" error. Original devel…
Jul 2, 2018
a5fa4d2
Merge pull request #1 from CryptoBridge/bugfix/fix-cannot-read-setnat…
Cryptolero Jul 2, 2018
20dc41b
Duration bug fixed
Jul 3, 2018
17eb4be
Merge pull request #2 from CryptoBridge/bugfix/fix-zero-duration-bug
Cryptolero Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/Toast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,12 @@ class Toast extends Component {
componentWillMount = () => {
this._toast = new RootSiblings(<ToastContainer
{...this.props}
duration={0}
/>);
};

componentWillReceiveProps = nextProps => {
this._toast.update(<ToastContainer
{...nextProps}
duration={0}
/>);
};

Expand Down
2 changes: 1 addition & 1 deletion lib/ToastContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class ToastContainer extends Component {
componentWillUnmount = () => {
Dimensions.removeEventListener('change', this._windowChanged);
Keyboard.removeListener('keyboardDidChangeFrame', this._keyboardDidChangeFrame);
this._hide();
this._root && this._hide();
};

_animating = false;
Expand Down