Conversation
bin/composer-require-checker.php
Outdated
|
|
||
| $foundAutoloadFile = true; | ||
| require $autoloadFileLocation; | ||
| $autoloader = require $autoloadFileLocation; |
There was a problem hiding this comment.
Hmm, this is something that shouldn't have been here in first place: it is scary dangerous, as it will mix autoloading definitions of this project and the analysed one.
Also, this effectively evaluates the "files" in a target project: big issue.
@WyriHaximus this is not a flaw in your patch, but in the design of this project
There was a problem hiding this comment.
Note: similar issues solved in roave/backwards-compatibility-check in Roave/BackwardCompatibilityCheck#120 - /cc @maglnet
There was a problem hiding this comment.
Anyway, it drills down to using the factories in Roave\BetterReflection\SourceLocator\Type\Composer\Factory\ to look up symbols.
There was a problem hiding this comment.
@WyriHaximus Maybe we can work together in another patch these suggestions, hm? 👍
There was a problem hiding this comment.
@carusogabriel sure what do you have in mind? Currently working on using better-reflection for class locating for this PR
|
@Ocramius Just pushed more changes, is this the direction you suggested? |
|
Looks like the right direction 👍 |
WyriHaximus
force-pushed
the
on-demand-symbol-loading
branch
from
a78abe9 to
eff90bc
Compare
3 participants
On Demand Symbol Loading using composers autoloader. The current way of pre-loading all vendor symbols is very slow. On the initial project I've added it to it takes five minutes. To bring that number down I've started hacking this PoC together to bring that number down. This PoC currently takes about 2 -3 seconds to do the same by trying to find the symbols using composers autoloader.
If this is something you'd be interested in I gladly work it out into a full feature tests and all.